[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rGba57828e11c5: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 __

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 updated this revision to Diff 454839. jhuber6 added a comment. Adding HIP test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/cuda-binding

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

yaxunl added a comment. In D132248#3736295 , @tra wrote: > I'm OK with that. > > @yaxunl -- what are your thoughts on whether this approach would work for > HIP? On one hand HIP already has a lot of features that the new driver is > intended to provide,

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

tra added a comment. I'm OK with that. @yaxunl -- what are your thoughts on whether this approach would work for HIP? On one hand HIP already has a lot of features that the new driver is intended to provide, so AMD may have no pressure to change to something else. On the other hand, long term

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 updated this revision to Diff 454076. jhuber6 added a comment. Updating to error with `-o` and multiple files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 Files: clang/lib/Driver/Driver.cpp

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 added a comment. In D132248#3735943 , @tra wrote: > In D132248#3735900 , @jhuber6 wrote: > >> Is this an architectural limitation? I'd imagine they'd just behave the same >> way here in my implementation.

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

tra added a comment. In D132248#3735900 , @jhuber6 wrote: > Is this an architectural limitation? I'd imagine they'd just behave the same > way here in my implementation. The constraint here is that we have to stick with a single output per compiler inv

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 added a comment. In D132248#3735793 , @tra wrote: >> The old driver would put all the outputs in the final action list akin to a >> linker job. > > IIRC that's where HIP and CUDA behaved differently. CUDA compilation does not > allow device-only

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

tra added a comment. > The old driver would put all the outputs in the final action list akin to a > linker job. IIRC that's where HIP and CUDA behaved differently. CUDA compilation does not allow device-only compilation for multiple targets if we have explicitly specified output. It does prod

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 updated this revision to Diff 454036. jhuber6 added a comment. Forgot to use the new driver in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 Files: clang/lib/Driver/Driver.cpp clan

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, JonChesterfield. Herald added subscribers: mattd, guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang