[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

2022-08-26 Thread Ilya Biryukov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa3270622f4: [clang] Add cxx scope if needed for requires clause. (authored by luken-google, committed by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D132503?vs=455622&id=455822#t

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

2022-08-26 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. I will commit this on behalf of Luke. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132503/new/ https://reviews.llvm.org/D132503 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

2022-08-25 Thread Luke Nihlen via Phabricator via cfe-commits
luken-google added a comment. Yes please, I'm hoping to earn committer rights with a series of C++20 patches :). Name is Luke Nihlen, email is lu...@google.com, github ID is luken-google@. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1325

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

2022-08-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? Comment at: clang/docs/Releas

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

2022-08-25 Thread Luke Nihlen via Phabricator via cfe-commits
luken-google added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:293 +if (Tok.is(tok::kw_requires)) { + CXXScopeSpec ScopeSpec = DeclaratorInfo.getCXXScopeSpec(); + DeclaratorScopeObj DeclScopeObj(*this, ScopeSpec); erichkeane wrote

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

2022-08-25 Thread Luke Nihlen via Phabricator via cfe-commits
luken-google updated this revision to Diff 455622. luken-google retitled this revision from "Add cxx scope if needed for requires clause." to "[clang] Add cxx scope if needed for requires clause.". luken-google added a comment. Make ScopeSpec a reference. Repository: rG LLVM Github Monorepo