[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

jdenny added a comment. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132513/new/ https://reviews.llvm.org/D132513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

awarzynski added a comment. I've skimmed through - these fixes make sense to me. Thank you for the quick summary! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132513/new/ https://reviews.llvm.org/D132513

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

jdenny added a comment. It was a small battle to get the tests past the windows bots, but they eventually succeeded: https://lab.llvm.org/buildbot/#/builders/216/builds/10125 I pushed the following additional patches while trying to fix the tests for windows: -

[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

This revision was automatically updated to reflect the committed changes. Closed by commit rG28412d1800e3: [lit] Implement DEFINE and REDEFINE directives (authored by jdenny). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES