[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a043c637646: PotentiallyEvaluatedContext in a ImmediateFunctionContext. (authored by usaxena95). Changed prior to commit: https://reviews.llvm.or

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132659/new/ https://reviews.llvm.org/D132659

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

usaxena95 updated this revision to Diff 455668. usaxena95 added a comment. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132659/new/ https://reviews.llvm.org/D132659 Files: clang/docs/ReleaseNotes.rst clang/include/clang/S

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

usaxena95 updated this revision to Diff 455667. usaxena95 marked 6 inline comments as done. usaxena95 added a comment. Thanks for the quick review. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132659/new/ https://reviews.llvm.o

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

aaron.ballman added reviewers: cor3ntin, aaron.ballman, clang-language-wg. aaron.ballman added a comment. Adding a few more reviewers just in case, but this is generally looking good. Please also add a release note for the fix! Comment at: clang/include/clang/Sema/Sema.h:1355

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

cor3ntin added a comment. Yes, this looks good to me too. Thanks for working on this. Can you modify ReleaseNotes.rst to mention the fixed issue? Comment at: clang/include/clang/Sema/Sema.h:1355 + InImmediateFunctionContext) || + // [expr.const#def:imm

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

shafik added a subscriber: cor3ntin. shafik added a comment. CC @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132659/new/ https://reviews.llvm.org/D132659 ___ cfe-commits mailing list cfe-commi

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

shafik added a comment. This looks good to me but I want another set of eyes on this. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:942 +} // namespace GH51182 \ No newline at end of file Please add a newline Repository: rG LLVM Github Monorepo CHANG

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132659 Files: clang/include/clang/Sema/Sema.h clan