[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7ce60536a6: [Clang] Avoid crashes when parsing using enum declarations (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

shafik updated this revision to Diff 456128. shafik marked an inline comment as done. shafik added a comment. - Move `DS.SetTypeSpecError()` outside the `if` so that it is always called when the diagnostic is triggered. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132695/new/ https://

[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. Thanks, this looks like it cleans up some needlessly chatty diagnostics! Just had a question that you can fix when landing if you agree, otherwise LGTM as well. Comment at: clang/lib/Parse/ParseDecl.cpp:4651

[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Changes seem correct enough, and the tests all look like we're just removing incorrect diagnostics, so LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132695/new/ https:/

[PATCH] D132695: [Clang] Avoid crashes when parsing using enum declarations

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman. Herald added a project: All. shafik requested review of this revision. In `Parser::ParseUsingDeclaration(...)` when we call `ParseEnumSpecifier(...)` it is not calling `SetTypeSpecError()` on `DS` when it detects an