[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith added a comment. In D132779#4523783 , @jansvoboda11 wrote: > Hi @rsmith, this commit makes it possible for `HeaderInfo::LookupFile()` to > be called with different `RequestingModule` within single `CompilerInstance`. > This is problematic,

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

jansvoboda11 added a comment. Hi @rsmith, this commit makes it possible for `HeaderInfo::LookupFile()` to be called with different `RequestingModule` within single `CompilerInstance`. This is problematic, since some modules may see headers other modules can't (due to

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa002063de37c: Enforce module decl-use restrictions and private header restrictions in textual… (authored by rsmith). Changed prior to commit:

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith updated this revision to Diff 458312. rsmith edited the summary of this revision. rsmith added a comment. - Help text update from Aaron. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132779/new/ https://reviews.llvm.org/D132779 Files:

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a suggestion to also document the command line reference. Thanks! Comment at: clang/include/clang/Driver/Options.td:2290 +

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:126 + `_ are now + diagnosed even when the includer is a textual header. aaron.ballman wrote: > You should mention

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith updated this revision to Diff 457742. rsmith added a comment. Document the flag to undo the behavior, and mention that it's going away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132779/new/ https://reviews.llvm.org/D132779 Files:

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

aaron.ballman added a comment. The changes look reasonable to me, though if you think the flag is a temporary one, we might want to consider changes to document that explicitly. Comment at: clang/docs/ReleaseNotes.rst:126 +

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith updated this revision to Diff 456077. rsmith added a comment. Add release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132779/new/ https://reviews.llvm.org/D132779 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith created this revision. rsmith added reviewers: Bigcheese, aaron.ballman. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per the documentation, these restrictions were intended to apply to textual