[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi added a comment. In D132801#3761253 , @akyrtzi wrote: > In D132801#3760014 , @rsmith wrote: > >> This doesn't look right to me -- we still use module maps when modules are >> disabled to enforce layering

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi added a comment. In D132801#3760014 , @rsmith wrote: > This doesn't look right to me -- we still use module maps when modules are > disabled to enforce layering checking, and when > `-fmodules-local-submodule-visibility` is enabled but

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

rsmith added a comment. This doesn't look right to me -- we still use module maps when modules are disabled to enforce layering checking, and when `-fmodules-local-submodule-visibility` is enabled but `-fmodules` is disabled we'll use them to provide modular semantics without pre-building

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

This revision was automatically updated to reflect the committed changes. akyrtzi marked an inline comment as done. Closed by commit rG33162a81d4c9: [driver] Additional ignoring of module-map related flags, if modules are… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/test/Driver/modules.m:81 // RUN: %clang -fno-modules -fmodules-validate-system-headers -### %s 2>&1 | FileCheck -check-prefix=VALIDATE_SYSTEM_FLAG %s // VALIDATE_SYSTEM_FLAG-NOT:

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi updated this revision to Diff 456483. akyrtzi added a comment. Merge the new `RUN` line together with the prior 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132801/new/ https://reviews.llvm.org/D132801 Files:

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

MaskRay accepted this revision. MaskRay added a comment. Herald added a subscriber: StephenFan. I sometimes need to debug builds by disabling modules. This behavior will make debugging easier. Comment at: clang/test/Driver/modules.m:81 // RUN: %clang -fno-modules

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132801 Files: