This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
tbaeder marked an inline comment as done.
Closed by commit rG4d700ffe67be: [clang][Interp] Implement
ImplicitValueInitExprs (authored by tbaeder).
Repository:
rG
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/arrays.cpp:13
+/// currently evaluate other parts of it.
+#if 0
+struct fred {
aaron.ballman wrote:
> I wish we could find some solution that didn't
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Comment at: clang/test/AST/Interp/arrays.cpp:13
+/// currently evaluate other parts of it.
+#if 0
+struct fred {
I wish we could find some solution that didn't require this so that
tbaeder updated this revision to Diff 456915.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132829/new/
https://reviews.llvm.org/D132829
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/lib/AST/Interp/Opcodes.td
aaron.ballman added a comment.
> I don't have a test case handy for them since I'm not sure how to trigger
> them reliably, but they are easy enough to implement and I ran into them
> while working on array fillers.
I think we should have test coverage for this if possible.
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
I assume we're going to see more patches in the future in this space as you
discover examples/tests for this, but in order to unblock other tests, this is
good enough for now.
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I don't have a test case handy for them since I'm
