This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5c4dbff0b6c3: [clang][Interp] Handle
SubstNonTypeTemplateParmExprs (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tbaeder updated this revision to Diff 457766.
tbaeder marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132831/new/
https://reviews.llvm.org/D132831
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM on the assumption that the extra test coverage doesn't find anything.
Comment at: clang/test/AST/Interp/functions.cpp:68-69
static_assert(recursion(10) == 0, "");
+
+
+template
tbaeder marked 3 inline comments as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273
+const SubstNonTypeTemplateParmExpr *E) {
+ return this->visit(E->getReplacement());
+}
tbaeder wrote:
> tahonermann wrote:
> >
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273
+const SubstNonTypeTemplateParmExpr *E) {
+ return this->visit(E->getReplacement());
+}
tahonermann wrote:
> erichkeane wrote:
> > tbaeder wrote:
> > > erichkeane wrote:
tahonermann added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273
+const SubstNonTypeTemplateParmExpr *E) {
+ return this->visit(E->getReplacement());
+}
erichkeane wrote:
> tbaeder wrote:
> > erichkeane wrote:
> > > Is there
erichkeane added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273
+const SubstNonTypeTemplateParmExpr *E) {
+ return this->visit(E->getReplacement());
+}
tbaeder wrote:
> erichkeane wrote:
> > Is there nothing special that has to
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273
+const SubstNonTypeTemplateParmExpr *E) {
+ return this->visit(E->getReplacement());
+}
erichkeane wrote:
> Is there nothing special that has to happen when these are
erichkeane added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273
+const SubstNonTypeTemplateParmExpr *E) {
+ return this->visit(E->getReplacement());
+}
Is there nothing special that has to happen when these are reference
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132831/new/
https://reviews.llvm.org/D132831
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
These
11 matches
Mail list logo
