[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

mstorsjo abandoned this revision. mstorsjo added a comment. Abandoned in favour of D132916 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132848/new/ https://reviews.llvm.org/D132848 _

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

efriedma added a comment. I'm not really happy with the way this implicitly ties the implementation of this function to the implementation of TargetMachine::useEmulatedTLS(). I'd prefer to just make clang always explicitly compute whether EmullatedTLS is enabled, then always set ExplicitEmulat

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding a few more reviewers for better opinions, but the changes look reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132848/new/ https://reviews.llv

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

mstorsjo created this revision. mstorsjo added a reviewer: aaron.ballman. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. We shouldn't just check the clang options, we also should check `Triple::hasDefaultEmulatedTLS()`. This doesn't make an