[PATCH] D13285: Fix for bug 24196: clang fails on assertion on complex doubles multiplication when EH is enabled

2015-09-30 Thread Denis Zobnin via cfe-commits
d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added reviewers: rsmith, rjmccall. d.zobnin.bugzilla added a subscriber: cfe-commits. This patch fixes an assertion failure, caused by EmitCall function producing llvm::InvokeInst* when llvm::CallInst* is needed (when multiplication of c

Re: [PATCH] D13285: Fix for bug 24196: clang fails on assertion on complex doubles multiplication when EH is enabled

2016-01-19 Thread Denis Zobnin via cfe-commits
d.zobnin.bugzilla abandoned this revision. d.zobnin.bugzilla added a comment. This issue is fixed in http://reviews.llvm.org/rL253926. http://reviews.llvm.org/D13285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D13285: Fix for bug 24196: clang fails on assertion on complex doubles multiplication when EH is enabled

2015-10-13 Thread John McCall via cfe-commits
rjmccall added a comment. This is an inappropriate fix for this problem. If these runtime functions can never throw, which seems to be the case, you should create the function type with a no-throw exception specification, which will make EmitCall emit the call with a CallInst. EST_BasicNoexce