[PATCH] D132867: [Clang] Use virtual FS in processing config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9424497e43af: [Clang] Use virtual FS in processing config files (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D132867

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132867/new/ https://reviews.llvm.org/D132867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/ReleaseNotes.rst:87-88 `Issue 57387 `_. +- Fix clang not properly handling configur

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff added a comment. In D132867#3771004 , @sammccall wrote: >> Strictly speaking this is incorrect behavior because file system object must >> be used for all operations on files, according to documentation. > > I don't think this is a strong argum

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff updated this revision to Diff 458205. sepavloff added a comment. Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132867/new/ https://reviews.llvm.org/D132867 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sammccall added a comment. In D132867#3770898 , @sepavloff wrote: > It seems that compatibility issue can appear if someone use VFS for all files > but configuration one, which reside in real FS. It is inconvenient and hard > to maintain I agree, the s

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff added a comment. In D132867#3769791 , @sammccall wrote: > This seems like the right thing in principle, but it's still pretty scary: > > - this is going to break anyone who's using VFS != RealFS together with > config files, as we no longer sea

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff updated this revision to Diff 458035. sepavloff added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132867/new/ https://reviews.llvm.org/D132867 Files: clang/lib/Driver/Driver.cpp clang/unittests/Driver/T

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sammccall added a comment. This seems like the right thing in principle, but it's still pretty scary: - this is going to break anyone who's using VFS != RealFS together with config files, as we no longer search the old locations - the breakage is likely to be quiet/subtle, especially if it's e.g

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff created this revision. sepavloff added reviewers: rjmccall, kadircet, sammccall. Herald added a subscriber: hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added projects: clang, LLVM. Clang has