rmaprath added a comment.
I've raised PR31966 to poke this :)
https://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petpav01 updated this revision to Diff 86217.
petpav01 added a comment.
Patch rebased.
https://reviews.llvm.org/D13289
Files:
include/valarray
test/std/numerics/numarray/valarray.nonmembers/valarray.transcend/abs_valarray.pass.cpp
test/std/numerics/numarray/valarray.nonmembers/valarray.
EricWF added a comment.
wow this is old. I'll try and re-review before the new year.
https://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jasonliu added a comment.
Ping.
Any review for this patch? It would be great if we can get this issue fixed.
https://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
petpav01 added a comment.
Ping. I would still like to address this problem. Could I please get a review
on the last version of the patch?
Thanks,
Petr
http://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
petpav01 updated this revision to Diff 42506.
petpav01 added a comment.
Updated patch adds more tests and fixes a problem introduced in the previous
revision where templates taking `__val_expr` were not correctly protected by
SFINAE from immediate context (it introduced same problem with explici
petpav01 updated this revision to Diff 40486.
petpav01 added a comment.
I am not sure if I understand the comment about [17.6.5.4] correctly. It is not
clear to me how this part of the standard prevents the user from specifying
explicit template parameters for standard functions. It seems odd th
petpav01 added a comment.
Thank you for having a look at this patch. I should get to updating it as
requested soon. Apologies for the delay.
http://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
One thing does need to change though. For each overload you added you need to
change all of the uses of `__is_val_expr` in the original overload to a new
metafunction that only accep
EricWF added a subscriber: EricWF.
EricWF added reviewers: EricWF, mclow.lists.
EricWF added a comment.
> This is required by the standard and is needed if the user tries to
> explicitly instantiate the transcendental functions using _Tp, for example,
> std::abs(int_valarray).
These may in fac
petpav01 added a comment.
It would be probably better if the patch changed the original templates to take
only `__val_expr` as there is now no need for them to match valarray too. This
should be a simple change but requires additional tests so I will wait for
initial feedback that this approach
petpav01 created this revision.
petpav01 added a subscriber: cfe-commits.
Libc++ provides valarray transcendentals with replacement types. These
functions are implemented either as `template` or `template`, where `_Expr` can be `__val_expr` or `valarray`.
The patch provides additional function t
12 matches
Mail list logo
