[PATCH] D132975: [CMake] Add clang-bolt target

Amir added a comment. In D132975#3861334 , @phosek wrote: > In D132975#3860896 , @Amir wrote: > >> In D132975#3763264 , @phosek wrote: >> >>> This was already on my list

[PATCH] D132975: [CMake] Add clang-bolt target

phosek added a comment. In D132975#3860896 , @Amir wrote: > In D132975#3763264 , @phosek wrote: > >> This was already on my list of build system features I'd like to implement >> and I'm glad someone else is

[PATCH] D132975: [CMake] Add clang-bolt target

Amir added a comment. In D132975#3763264 , @phosek wrote: > This was already on my list of build system features I'd like to implement > and I'm glad someone else is already looking into it, thank you! I have two > high level comments about your

[PATCH] D132975: [CMake] Add clang-bolt target

This revision was automatically updated to reflect the committed changes. Closed by commit rG3dab7fede201: [CMake] Add clang-bolt target (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975

[PATCH] D132975: [CMake] Add clang-bolt target

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459588. Amir added a comment. Add an ability to pass extra cmake flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as not done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459539. Amir added a comment. Address @phosek's comment about dependency on shell Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D132975: [CMake] Add clang-bolt target

MaskRay added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGXX_INSTRUMENTED} +