[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir added a comment. In D132975#3768391 , @tschuett wrote: > Will there be eventually a way to build a fully optimised clang/lld with > ThinLTO, PGO, and Bolt? Short answer is likely yes. For clang, I think this diff should be compatible with PGO,

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

tschuett added a comment. Will there be eventually a way to build a fully optimised clang/lld with ThinLTO, PGO, and Bolt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

phosek added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGXX_INSTRUMENTED} +

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

phosek added a comment. In D132975#3765541 , @Amir wrote: > Hi Petr, thank you for your comments! > > In D132975#3763264 , @phosek wrote: > >> This was already on my list of build system features I'd like to

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir updated this revision to Diff 457467. Amir added a comment. Fix up paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake Index:

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir added a comment. Hi Petr, thank you for your comments! In D132975#3763264 , @phosek wrote: > This was already on my list of build system features I'd like to implement > and I'm glad someone else is already looking into it, thank you! I have two

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457400. Amir added a comment. Succeeded in producing optimized Clang. Switch the default profiling target from `lld` to `count`, which produces a sufficient Clang coverage of 5.3B exec insns (along with configure-stage Clang invocations). Repository: rG

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

phosek added a comment. This was already on my list of build system features I'd like to implement and I'm glad someone else is already looking into it, thank you! I have two high level comments about your approach. The first one is related to the use of Clang build as the training data. I

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457172. Amir added a comment. Successfully invoke the bootstrap/profiling build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457102. Amir added a comment. Succeeded instrumenting Clang with BOLT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 456799. Amir added a comment. CMAKE_CURRENT_BINARY_DIR already contains bin/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt