[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3846907 , @aaron.ballman wrote: > In D133066#3845136 , @zhouyizhou > wrote: > >> After 4 weeks' study, I think the comment didn't need to be changed, sorry >> to have

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. In D133066#3845136 , @zhouyizhou wrote: > After 4 weeks' study, I think the comment didn't need to be changed, sorry to > have bring your so much trouble. No worries at all, there was no trouble here! > During this

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. After 4 weeks' study, I think the comment didn't need to be changed, sorry to have bring your so much trouble. During this valuable process of studying, I grow up a lot. I learned to read the C++ standard, and compare the standard to its implementation. In my case,

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. my current progress - succesfully build commit cba72b1f620fd on debian6: 1. git checkout cba72b1f620fd 2. download debian-6.0.10-amd64-DVD-1.iso and use it to create a debian6 virtual machine 3. debian6/llvm-project>cp -fr clang llvm/tools 4. modifiy

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3780900 , @aaron.ballman wrote: > In D133066#3768091 , @zhouyizhou > wrote: > >> In D133066#3767146 , >> @aaron.ballman wrote:

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. In D133066#3768091 , @zhouyizhou wrote: > In D133066#3767146 , @aaron.ballman > wrote: > >> In D133066#3765503 , @zhouyizhou >> wrote:

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3767146 , @aaron.ballman wrote: > In D133066#3765503 , @zhouyizhou > wrote: > >> In D133066#3764384 , >> @aaron.ballman wrote:

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. In D133066#3765503 , @zhouyizhou wrote: > In D133066#3764384 , @aaron.ballman > wrote: > >> The existing comment is correct according to my copy of the C++11 standard, >> but the

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3764384 , @aaron.ballman wrote: > The existing comment is correct according to my copy of the C++11 standard, > but the standard has changed since C++11 and those words no longer appear in >

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. The existing comment is correct according to my copy of the C++11 standard, but the standard has changed since C++11 and those words no longer appear in http://eel.is/c++draft/dcl.init.ref#5. Some more investigation is needed, but I suspect the correct action to

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou created this revision. zhouyizhou added reviewers: MikeStump, riccibruno, rsmith. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi I think the comment above the condition expression