This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGacb767f5cda5: [clang] fix profiling of template arguments of
template and declaration kind (authored by mizvekov).
Change
mizvekov added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:5817
// fall back to just producing individual arguments.
- Converted.insert(Converted.end(),
- ArgumentPack.begin(), ArgumentPack.end());
+ for (con
mizvekov edited the summary of this revision.
mizvekov updated this revision to Diff 457819.
mizvekov marked 2 inline comments as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133072/new/
https://reviews.llvm.org/D133072
Files:
clang/lib/AST
mizvekov added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:5817
// fall back to just producing individual arguments.
- Converted.insert(Converted.end(),
- ArgumentPack.begin(), ArgumentPack.end());
+ for (con
erichkeane accepted this revision.
erichkeane added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:5119
// Find the insert position again.
-DependentTemplateSpecializationTypes.FindNodeOrInsertPos(ID, InsertPos);
+[[maybe_unused]] auto *Nothing =
+
mizvekov added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:5119
// Find the insert position again.
-DependentTemplateSpecializationTypes.FindNodeOrInsertPos(ID, InsertPos);
+[[maybe_unused]] auto *Nothing =
+DependentTemplateSpecializationTypes.
erichkeane added a comment.
Generally happy here. Two quick suggestions, otherewise LGTM.
Comment at: clang/lib/AST/ASTContext.cpp:5119
// Find the insert position again.
-DependentTemplateSpecializationTypes.FindNodeOrInsertPos(ID, InsertPos);
+[[maybe_unused]] a
