[PATCH] D133157: Add -sanitizer-coverage-control-flow

2022-09-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > Add -sanitizer-coverage-control-flow Add -fsanitizer-coverage=control-flow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 ___

[PATCH] D133157: Add -sanitizer-coverage-control-flow

2022-09-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/SanitizerCoverage.rst:338 + +With ``-fsanitize-coverage=control-flow`` the compiler will create a table to collect +control flow for each function. More specifically, for each basic block in the function,

[PATCH] D133157: Add -sanitizer-coverage-control-flow

2022-09-02 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:4 +// RUN: %clangxx -O0 -std=c++11 -fsanitize-coverage=control-flow %s -o %t +// RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not

[PATCH] D133157: Add -sanitizer-coverage-control-flow

2022-09-02 Thread Navid Emamdoost via Phabricator via cfe-commits
Navidem updated this revision to Diff 457754. Navidem added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Added an initial run-time test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/

[PATCH] D133157: Add -sanitizer-coverage-control-flow

2022-09-02 Thread Navid Emamdoost via Phabricator via cfe-commits
Navidem added inline comments. Comment at: llvm/test/Instrumentation/SanitizerCoverage/control-flow.ll:2 +; Test -sanitizer-coverage-control-flow +; RUN: opt < %s -passes='module(sancov-module)' -sanitizer-coverage-level=3 -sanitizer-coverage-control-flow -S | FileCheck %s +

[PATCH] D133157: Add -sanitizer-coverage-control-flow

2022-09-02 Thread Navid Emamdoost via Phabricator via cfe-commits
Navidem added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1055 + for (auto : F) { +// blockaddress may not be used on function's entry block. +if ( == ()) Navidem wrote: > kcc wrote: > > vitalybuka wrote: > > >

[PATCH] D133157: Add -sanitizer-coverage-control-flow

2022-09-02 Thread Navid Emamdoost via Phabricator via cfe-commits
Navidem updated this revision to Diff 457734. Navidem added a comment. Herald added subscribers: cfe-commits, ormris, MaskRay. Herald added a project: clang. Updated docs, lit test, and added clang option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION