This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5b5329bd41ba: [NFC] Make MultiplexExternalSemaSource own
sources (authored by beanz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
beanz added a comment.
I built LLDB and ran its tests. I see no additional failures after applying my
change, but LLDB's tests do not execute successfully on my local system (22
failures).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133158/new/
beanz updated this revision to Diff 457651.
beanz added a comment.
Herald added a project: clang-tools-extra.
Updating with changes based on review feedback, and fixups for clang-tools-extra
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133158/new/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from some minor nits (also, please run clang-format over the patch
before landing).
Comment at: clang/lib/Sema/MultiplexExternalSemaSource.cpp:32
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
This looks plausible to me — did you build clang-tools-extra & lldb to make
sure nothing else needs to be updated?
Comment at:
beanz added inline comments.
Comment at: clang/include/clang/Sema/MultiplexExternalSemaSource.h:53
///
- MultiplexExternalSemaSource(ExternalSemaSource& s1, ExternalSemaSource& s2);
+ MultiplexExternalSemaSource(ExternalSemaSource* S1, ExternalSemaSource* S2);
aprantl added inline comments.
Comment at: clang/include/clang/Sema/MultiplexExternalSemaSource.h:53
///
- MultiplexExternalSemaSource(ExternalSemaSource& s1, ExternalSemaSource& s2);
+ MultiplexExternalSemaSource(ExternalSemaSource* S1, ExternalSemaSource* S2);
beanz created this revision.
beanz added reviewers: rsmith, aaron.ballman, python3kgae, akyrtzi, aprantl.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project: clang.
This change refactors the MuiltiplexExternalSemaSource to take ownership
of the underlying
