This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1a4d851d272d: [MinGW] Ignore
-fvisibility/-fvisibility-inlines-hidden for dllexport (authored by MaskRay).
Repository:
rG LLVM Github Monorepo
MaskRay updated this revision to Diff 457625.
MaskRay marked an inline comment as done.
MaskRay added a comment.
rename test to dllstorage-visibility.cpp
use -fdeclspec instead of -fms-extensions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
This LGTM, but one question about the test. Thanks!
Comment at: clang/test/CodeGenCXX/dllstorage-hidden.cpp:3
+
+// RUN: %clang_cc1 -triple x86_64-windows-msvc
MaskRay updated this revision to Diff 457483.
MaskRay added a comment.
improve test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133180/new/
https://reviews.llvm.org/D133180
Files:
clang/lib/CodeGen/CodeGenModule.cpp
