Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

2015-09-30 Thread David Li via cfe-commits
davidxl added a comment. With this patch, 11M bytes (text section) can be shaved off clang build with instrumentation. http://reviews.llvm.org/D13319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13319: Eliminate __llvm_profile_register calls

2015-09-30 Thread David Li via cfe-commits
davidxl created this revision. davidxl added reviewers: bogner, rsmith. davidxl added subscribers: cfe-commits, llvm-commits. Herald added subscribers: srhines, danalbert, tberghammer. With PGO, the instrumented binary needs to dump __llvm_prf_data, __llvm_prf_cnts, and __llvm_prf_names data

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

2015-09-30 Thread Richard Smith via cfe-commits
rsmith added a comment. Clang changes LGTM. http://reviews.llvm.org/D13319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

2015-09-30 Thread David Li via cfe-commits
davidxl abandoned this revision. davidxl added a comment. Will split the patch into 3. http://reviews.llvm.org/D13319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

2015-09-30 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Driver/ToolChains.cpp:2191-2193 @@ +2190,5 @@ + + SmallString<128> Path(getDriver().ResourceDir); + llvm::sys::path::append(Path, "prf_data.x"); + CmdArgs.push_back(Args.MakeArgString(Path)); + return true; Please

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

2015-09-30 Thread Justin Bogner via cfe-commits
David Li writes: > davidxl created this revision. > davidxl added reviewers: bogner, rsmith. > davidxl added subscribers: cfe-commits, llvm-commits. > Herald added subscribers: srhines, danalbert, tberghammer. > > With PGO, the instrumented binary needs to dump