[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. Thanks for your review @aaron.ballman , I've updated ReleaseNotes. I don’t have commit access, can you land this patch for me?Please use 'yronglin ' to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin updated this revision to Diff 458315. yronglin added a comment. Update ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but can you add a release note to clang/docs/ReleaseNotes.rst for the fix? Also, do you need someone to commit this on your behalf? If so, what name and email address

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin updated this revision to Diff 458019. yronglin added a project: Sanitizers. yronglin added a comment. Fix windows build bolt broken https://lab.llvm.org/buildbot/#/builders/127/builds/35304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. In D133202#3768770 , @vitalybuka wrote: > Broken by the patch https://lab.llvm.org/buildbot/#/builders/127/builds/35304 Thanks @vitalybuka , seems `intrin0.inl.h` have a forward declaration `__MACHINE(void * __cdecl

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

vitalybuka added a comment. Broken by the patch https://lab.llvm.org/buildbot/#/builders/127/builds/35304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 ___

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad2fe913ae0: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array… (authored by yronglin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. In D133202#3767414 , @rjmccall wrote: > Thanks, LGTM Thanks for your review John, but I don’t have commit access, can you land this patch for me? Please use "yronglin " to commit the change. Repository: rG LLVM Github

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7697 // The alignment must be a constant integer. - Expr *Arg = TheCall->getArg(1); + Expr *SecondArg = TheCall->getArg(1); rjmccall wrote: > This should be: > > ``` > Expr

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin updated this revision to Diff 457643. yronglin added a comment. Update patch with john's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rjmccall added a comment. Other than the one thing, this looks good. Comment at: clang/lib/Sema/SemaChecking.cpp:7697 // The alignment must be a constant integer. - Expr *Arg = TheCall->getArg(1); + Expr *SecondArg = TheCall->getArg(1); This should be: