[PATCH] D133229: [driver] Prune module-map related flags, if they are not going to be needed

2022-09-02 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi added a comment. In D133229#3768101 , @rsmith wrote: > I think the approach you're taking here is probably doomed -- too many things > in Clang depend on whether we've read module map files, and it seems unlikely > to me that you'll be able to

[PATCH] D133229: [driver] Prune module-map related flags, if they are not going to be needed

2022-09-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I've landed some tests for the specific functionality that intends to use modules info under `-fno-modules` in b484256f59850e702df4d4532c5f31f478879bb9 . I think the approach you're taking here is

[PATCH] D133229: [driver] Prune module-map related flags, if they are not going to be needed

2022-09-02 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This is follow-up from https://reviews.llvm.org/D132801, but taking into account the conditions where the