Re: [PATCH] D13326: [PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs

2015-10-21 Thread David Li via cfe-commits
davidxl added a comment. It turns out previous refactoring by another commit only covers half of the work. Will update the patch with Justin's comments and commit after testing. http://reviews.llvm.org/D13326 ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D13326: [PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs

2015-10-21 Thread David Li via cfe-commits
davidxl updated this revision to Diff 38091. davidxl added a comment. Updated patch. http://reviews.llvm.org/D13326 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp

Re: [PATCH] D13326: [PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs

2015-10-21 Thread David Li via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250994: clang driver toolchain refactoring (authored by davidxl). Changed prior to commit: http://reviews.llvm.org/D13326?vs=38091&id=38092#toc Repository: rL LLVM http://reviews.llvm.org/D13326 Fi