[PATCH] D133423: [clangd] Improve Selection testcase, pin to C++17

2022-09-07 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8af74da5bdbd: [clangd] Improve Selection testcase, pin to C++17 (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D133423?vs=458445=458450#toc Repository: rG LLVM Github

[PATCH] D133423: [clangd] Improve Selection testcase, pin to C++17

2022-09-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. can you wait for premerge checks to finish (especially for windows)? Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:729-730

[PATCH] D133423: [clangd] Improve Selection testcase, pin to C++17

2022-09-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. 17 vs 14