[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

2022-09-08 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG71c4fb1d6482: [clangd] Set Incompleteness for spec fuzzyfind requests (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D133479?vs=458690=458774#toc Repository: rG LLVM

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

2022-09-08 Thread David Goldman via Phabricator via cfe-commits
dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1716 + Incomplete |= SpecRes.first; + return std::move(SpecRes.second); } dgoldman wrote: > Can this be safely moved - looks like it wasn't before? Ah nevermind,

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

2022-09-08 Thread David Goldman via Phabricator via cfe-commits
dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1716 + Incomplete |= SpecRes.first; + return std::move(SpecRes.second); } Can this be safely moved - looks like it wasn't before? Repository: rG LLVM Github

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

2022-09-08 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: sammccall, dgoldman. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.