domada marked an inline comment as done.
domada added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:629
+ llvm::ArrayRef AlignedVars,
+ llvm::Value *Alignment, Value *IfCond, ConstantInt *Simdlen,
C
domada updated this revision to Diff 459697.
domada added a comment.
Applied review remarks. Scope of changes:
1. replaced ArrayRef AlignedVars, Value * Alignment arguments with
DenseMap. It allows to generate different alignment assumption for different
variables. OpenMP allows to specify mult
jdoerfert added a comment.
Thanks for this patch! I have two drive by comments that should probably be
addressed first.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:629
+ llvm::ArrayRef AlignedVars,
+ llvm::Value *Alignment, Valu
domada created this revision.
domada added a reviewer: kiranchandramohan.
Herald added subscribers: bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr,
cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,
Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,