[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Compilation.h:134 + + llvm::SmallDenseMap TimeTraceFiles; + I don't think we should use a non-zero inline element for these members. They are, in 99.9% cases, empty. We should optimize for th

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

MaskRay added a comment. At a glance the approach looks more elegant to me, but I haven't studied this carefully yet. Also thanks for checking how to handle offloading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133662/new/ https://reviews.llvm

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

Maetveis added a comment. In D133662#3787250 , @jamieschmeiser wrote: > I'm a little confused as to what is being proposed here. Is this building on > D131469 or is it an alternative? It seems > that there are porti

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

jamieschmeiser added a comment. I'm a little confused as to what is being proposed here. Is this building on D131469 or is it an alternative? It seems that there are portions of the code from D131469 included in these chang