martong updated this revision to Diff 469625.
martong marked 8 inline comments as done.
martong added a comment.
- Add comments
- Assumption -> ConditionValue
- Use CRTP
- branchTransfer -> transferBranch
- Make just one simple test case for transferBranch
Repository:
rG LLVM Github Monorepo
martong planned changes to this revision.
martong added a comment.
Aligned with the RFC, I am going to dissect this patch into two patches:
1. This patch will remain a simple infrastructural change that introduces
transferBranch. This could be useful for complex lattices (e.g integer value
rang
dkrupp added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:241
+? SignLattice(R.Val.getInt().getExtValue())
+: SignLattice::bottom();
+ } else {
Isn't this SignLattice
gribozavr2 added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:127
+ // Default implementation is a Noop.
+ virtual void branchTransfer(bool Branch, const Stmt *S, Lattice &L,
+ Environment &Env) {}
-
martong created this revision.
martong added reviewers: xazax.hun, gribozavr2, sgatev, ymandel, samestep.
Herald added subscribers: steakhal, gamesh411, Szelethus, dkrupp, rnkovacs,
mgorny.
Herald added a reviewer: Szelethus.
Herald added a reviewer: NoQ.
Herald added a project: All.
martong reque
