[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

This revision was automatically updated to reflect the committed changes. Closed by commit rGedbf36c5e9e8: [HLSL] [clang] Add vector version of abs for HLSL (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https:/

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737 _

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

python3kgae updated this revision to Diff 461039. python3kgae added a comment. Only allow redecl custom type checking builtin for HLSL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737 Files: clang/lib/A

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. In D133737#3787066 , @RKSimon wrote: > The elementwise builtins should work for scalars as well (and IIRC we do test > this as well). Yep they should, it is specially specified here: https://clang.llvm.org/docs/LanguageExtensions

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

RKSimon added a comment. The elementwise builtins should work for scalars as well (and IIRC we do test this as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737 _

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

beanz added a comment. In D133737#3785987 , @fhahn wrote: > I'm not familiar with HLSL but I think making use of the existing vector > builtins makes sense here! Does it make sense to be using the vector builtin for non-vectors? Repository: rG LLVM

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. I'm not familiar with HLSL but I think making use of the existing vector builtins makes sense here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, fhahn, RKSimon. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add vecto