[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman closed this revision. aaron.ballman added a comment. In D133800#3789377 , @aaron.ballman wrote: > In D133800#3787378 , @thieta wrote: > >> I think the easiest way to handle this is that when you hav

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. In D133800#3787378 , @thieta wrote: > I think the easiest way to handle this is that when you have it approved here > - push it to fork on GitHub based on the release branch and create a GitHub > issue and write /branch ab

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. The newest version looks good. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___ cfe-

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman updated this revision to Diff 460051. aaron.ballman added a comment. Added the `not` back into the neon-crypto.c test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. In D133800#3789188 , @mgorny wrote: > In D133800#3789100 , @aaron.ballman > wrote: > >> In D133800#3788950 , @nikic wrote: >> >>> I tested

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. In D133800#3789100 , @aaron.ballman wrote: > In D133800#3788950 , @nikic wrote: > >> I tested this patch as well and saw the same failures as @mgorny. > > Thank you, I think I've got those

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. In D133800#3788983 , @nikic wrote: > @mgorny Yeah, that was a testing fail on my side. I've updated it to a > hopefully correct version. Ok, thanks. This version worked for me. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. In D133800#3788950 , @nikic wrote: > I tested this patch as well and saw the same failures as @mgorny. Thank you, I think I've got those patched up, but with one difference: > > diff --git a/clang/test/CodeGen/neon-cr

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman updated this revision to Diff 460035. aaron.ballman added a comment. Herald added subscribers: kbarton, nemanjai. Updated the failing tests caught during review (thank you!) and moved the release notes around and reworded them somewhat for clarity. CHANGES SINCE LAST ACTION http

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

nikic added a comment. @mgorny Yeah, that was a testing fail on my side. I've updated it to a hopefully correct version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 __

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. @nikic, with your patch I still have `CodeGen/PowerPC/builtins-ppc-p8vector.c` failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

nikic added a comment. I tested this patch as well and saw the same failures as @mgorny. Here's the additional patch I had to apply to make this pass: diff --git a/clang/test/CodeGen/PowerPC/builtins-ppc-p8vector.c b/clang/test/CodeGen/PowerPC/builtins-ppc-p8vector.c index af3d5c7d066b..3c5

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. Hmm, I just realized that I've tested on top of 15.0.0. If commits already on top of `release/15.x` branch already fix that, I'm sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. I'm seeing test failures with this patch applied: Failed Tests (3): Clang :: CodeGen/PowerPC/builtins-ppc-p8vector.c Clang :: CodeGen/builtins-arm-msvc-compat-only.c Cla

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. Thanks for doing this. I'm going to test it in 2-3 hours and get back to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___ cfe-co

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added reviewers: rjmccall, jyknight, MaskRay. aaron.ballman added a comment. Herald added a subscriber: StephenFan. In D133800#3787378 , @thieta wrote: > I think the easiest way to handle this is that when you have it approved here > - push

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

thieta added a comment. I think the easiest way to handle this is that when you have it approved here - push it to fork on GitHub based on the release branch and create a GitHub issue and write /branch aballman/llvm-project/my_branch in a comment and it will queue up the cherry pick. Reposito

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. @thieta and @tstellar -- because these changes are expected to go into the 15.0.1 branch, not the current main branch, it wasn't clear to me what the best way to go about the review (whether I should submit a Phab request or make a fork of Clang and submit a GitH

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman created this revision. aaron.ballman added reviewers: mgorny, thieta, tstellar. Herald added a subscriber: jdoerfert. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The changes in Clang 15.0.0 which enabled these diagnosti