Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2016-02-21 Thread Milian Wolff via cfe-commits
milianw closed this revision. milianw added a comment. closing then, since this has been landed http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-11-23 Thread Ehsan Akhgari via cfe-commits
ehsan accepted this revision. ehsan added a reviewer: ehsan. ehsan added a comment. Landed in r253909. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-11-18 Thread Michael Wu via cfe-commits
michaelwu added a comment. Anyone mind landing this for me? I don't have commit access. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-11-14 Thread Milian Wolff via cfe-commits
milianw accepted this revision. milianw added a comment. This revision is now accepted and ready to land. From my POV, this looks good. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-11-04 Thread Michael Wu via cfe-commits
michaelwu added inline comments. Comment at: test/Index/symbol-visibility.c:8 @@ +7,3 @@ +// CHECK: FunctionDecl=foo1:3:47visibility=Default +// CHECK: FunctionDecl=foo2:4:49visibility=Protected +// CHECK: FunctionDecl=foo3:5:46visibility=Hidden skalinichev

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-11-03 Thread Sergey Kalinichev via cfe-commits
skalinichev added a comment. Well, I think it's ok then. Still there is no test for visibility set from command line case. Also adding comment to clang_getCursorVisibility explaining that it also works with visibility set from command line would be very useful. Comment at:

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-29 Thread Michael Wu via cfe-commits
michaelwu added a comment. Review ping? http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-17 Thread Michael Wu via cfe-commits
michaelwu added a comment. Visibility can be set via command line args without any attributes in the AST, so I don't think that's sufficient. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-17 Thread Sergey Kalinichev via cfe-commits
skalinichev added a comment. Isn't r246931 what you're looking for? > Index: expose visibility attribute > > Expose the previously unexposed visibility attribute via the python and C > bindings. Can't you use/improve that API instead? http://reviews.llvm.org/D13388

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-13 Thread Manuel Klimek via cfe-commits
klimek added a subscriber: klimek. klimek added a reviewer: milianw. klimek added a comment. This LG, looping in Milian for a second opinion / to find more reviewers :) http://reviews.llvm.org/D13388 ___ cfe-commits mailing list

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-13 Thread Milian Wolff via cfe-commits
milianw added a comment. Yep, looks good to me as well - thanks! http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13388: Add support for querying the visibility of a cursor

2015-10-02 Thread Michael Wu via cfe-commits
michaelwu created this revision. michaelwu added a subscriber: cfe-commits. This patch implements clang_getCursorVisibility which provides access to NamedDecl::getVisibility. It's been very useful for me when generating bindings. http://reviews.llvm.org/D13388 Files: include/clang-c/Index.h