[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

This revision was automatically updated to reflect the committed changes. Closed by commit rG46bb4b99ae9f: [X86][fastcall][vectorcall] Move capability check before free register update (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

pengfei updated this revision to Diff 461072. pengfei added a comment. Missing a `!`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/TargetInfo.cp

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

pengfei updated this revision to Diff 461071. pengfei added a comment. Address review comments. Thanks @rnk! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920 Files: clang/docs/ReleaseNotes.rst clang/li

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

rnk added a comment. Thanks, I have more comments, sorry I didn't add them on the first review. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1785 - if (State.CC == llvm::CallingConv::X86_FastCall || - State.CC == llvm::CallingConv::X86_VectorCall || - State.CC == l