[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

This revision was automatically updated to reflect the committed changes. Closed by commit rG587729c3ad78: [clang] [Driver] Add an option to disable default config filenames (authored by mgorny). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D134018?vs=460665&

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

sepavloff accepted this revision. sepavloff added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny marked 6 inline comments as done. mgorny added a comment. Thanks! I'm going to give others a few more hours to chime in before merging it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018 ___ c

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/config-file3.c:44 + +//--- --no-default-config disables config search +// Append `.` after a complete sentence in a comment. Comment at: clang/test/Dri

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv7l-clang.cfg'.

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny updated this revision to Diff 460665. mgorny added a comment. Replace `!x || !y` logic with `!(x && y)` that may be easier to comprehend. Replace `//` with empty lines on test boundaries. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance,

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv7l-clang.cfg'.

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

MaskRay added a comment. This makes sense. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny created this revision. mgorny added reviewers: sepavloff, asymptotically, MaskRay, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Add a `--no-default-config` option that disables the search for default set of config fi