[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a774c35e9f8: [clang] [Driver] Support multiple configuration files (authored by mgorny). Herald added a project: clang. Repository: rG LLVM

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1061 return false; + if (ClangNameParts.TargetPrefix.empty()) +return false; sepavloff wrote: > Does it mean that executable without prefix won't load implicit config file? > For

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1061 return false; + if (ClangNameParts.TargetPrefix.empty()) +return false; Does it mean that executable without prefix won't load implicit config file? For example, execution

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. For the record, I'm working on support for loading defaults from multiple files in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny updated this revision to Diff 461803. mgorny added a comment. Combining `--config` and default configuration files is now explicitly allowed. Adjust the code to load default configs before explicitly specified files. Update tests to cover combining `--config` with defaults. Update the

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. In D134270#3804855 , @sepavloff wrote: > What about the case, when executable file has a target prefix (so implicit > config file may be used) and the option `--config` is specified in command > line? Now this case becomes

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

sepavloff added a comment. What about the case, when executable file has a target prefix (so implicit config file may be used) and the option `--config` is specified in command line? Now this case becomes possible and we should either reject it (because explicit config files have precedence)

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Support specifying multiple configuration files via multiple `--config` options. When multiple files are