[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3618 + /// The source location of the 'enum' keyword. + SourceLocation EnumLoc; + /// 'qual::SomeEnum' as an EnumType, possibly with Elaborated/Typedef sugar. hokein wrote: > nit:

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 5 inline comments as done. Closed by commit rG2eaf6f973cac: [AST] Preserve more structure in UsingEnumDecl node. (authored by sammccall). Changed

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

hokein accepted this revision. hokein added a comment. it looks good to me, just a few optional nits. Comment at: clang/include/clang/AST/DeclCXX.h:3618 + /// The source location of the 'enum' keyword. + SourceLocation EnumLoc; + /// 'qual::SomeEnum' as an EnumType,

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Modelling this as a `TypeLoc` for code reuse reasons gives me a pause too. However, I think we still accept this as keeping the clients simpler seems like the right trade-off to

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a reviewer: hokein. sammccall added a comment. ping, +additional potential reviewer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134303/new/ https://reviews.llvm.org/D134303 ___

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall updated this revision to Diff 464118. sammccall added a comment. Rebase on top of using enum parsing changes, store 'enum' location separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134303/new/ https://reviews.llvm.org/D134303

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a comment. In D134303#3823620 , @urnathan wrote: > Does this still apply with the fix for dr2621 landed? Not cleanly, as getType already creates the ElaboratedTypeLoc for the qualifier but without the `enum` keyword. Wrapping it with a

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

urnathan added a comment. Does this still apply with the fix for dr2621 landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134303/new/ https://reviews.llvm.org/D134303 ___ cfe-commits mailing list

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4866 auto ToUsingLoc = importChecked(Err, D->getUsingLoc()); - auto ToEnumLoc = importChecked(Err, D->getEnumLoc()); + auto ToEnumLoc = importChecked(Err, D->getEnumType()); auto ToEnumDecl =

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a comment. In D134303#3805687 , @urnathan wrote: > AFAICT the UsingDecl doesn't capture the NestedNameSpecifier location We have `NestedNameSpecifierLoc UsingDecl::QualifierLoc` already, maybe I'm misunderstanding. > is UsingEnumDecl

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

urnathan added a comment. AFAICT the UsingDecl doesn't capture the NestedNameSpecifier location, is UsingEnumDecl special in some way, or would this information be better placed in BaseUsingDecl? Thanks for spotting the possible mid-air collistion with D134283

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a comment. I just saw this touches the same code as @urnathan's D134283 , specifically `Sema::ActOnUsingEnumDeclaration`. I'm happy to wait for that to land and then merge, I think these will play nicely together. The changes to the actual

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, urnathan. Herald added subscribers: kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra.