[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

2022-09-27 Thread Stefan Gränitz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGed8409dfa0a9: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

2022-09-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134441/new/ https://reviews.llvm.org/D134441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

2022-09-26 Thread Stefan Gränitz via Phabricator via cfe-commits
sgraenitz added a comment. In D134441#3814794 , @fhahn wrote: > LGTM, thanks! You might want to extend the windows check lines to the other > tests as well. Thanks. Yes thought about that, but not all of them match the typical IR output on Windows (gxx

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

2022-09-26 Thread Florian Hahn via Phabricator via cfe-commits
fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! You might want to extend the windows check lines to the other tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134441/ne