[PATCH] D134544: [clang-cl] Implement /ZH: flag

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:3220 Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>; +def gsrc_hash_EQ : Joined<["-"], "gsrc-hash=">, + Group, Flags<[CC1Option, NoDriverOption]>, thakis wrote

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Driver/Options.td:3220 Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>; +def gsrc_hash_EQ : Joined<["-"], "gsrc-hash=">, + Group, Flags<[CC1Option, NoDriverOption]>, dblaikie wrote

[PATCH] D134544: [clang-cl] Implement /ZH: flag

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:3220 Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>; +def gsrc_hash_EQ : Joined<["-"], "gsrc-hash=">, + Group, Flags<[CC1Option, NoDriverOption]>, This is a dr

[PATCH] D134544: [clang-cl] Implement /ZH: flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8371247f63: [clang-cl] Implement /ZH: flag (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:106 + enum SrcHashAlgorithm { +CSK_MD5, +CSK_SHA1, hans wrote: > thakis wrote: > > hans wrote: > > > what does CSK stand for here? > > I'm guessing "check sum kind", but

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462731. thakis added a comment. final tweaks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/includ

[PATCH] D134544: [clang-cl] Implement /ZH: flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Basic/CodeGenOptions.h:106 + enum SrcHashAlgorithm { +CSK_MD5, +CSK_SHA1, thakis wrote: > hans wrote: > > what does

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462596. thakis added a comment. don't accidentally add a flag for this to the gcc-style driver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/i

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-check

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-check

[PATCH] D134544: [clang-cl] Implement /ZH: flag

probinson added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-ch

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:344 +/// Set debug info source file hashing algorithm +ENUM_CODEGENOPT(DebugSrcHashAlgorithm, SrcHashAlgorithm, 2, CSK_MD5) hans wrote: > ultra nit: period. But maybe the com

[PATCH] D134544: [clang-cl] Implement /ZH: flag

hans added a comment. nice! Comment at: clang/include/clang/Basic/CodeGenOptions.def:344 +/// Set debug info source file hashing algorithm +ENUM_CODEGENOPT(DebugSrcHashAlgorithm, SrcHashAlgorithm, 2, CSK_MD5) ultra nit: period. But maybe the comment is superf

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added a comment. In D134544#3811867 , @probinson wrote: > Probably we should reject the -gsrc... option if we're emitting DWARF, which > requires MD5 (at least so far). It's a cc1 option. As those aren't considered user facing, we don't do a lot

[PATCH] D134544: [clang-cl] Implement /ZH: flag

probinson added a project: debug-info. probinson added a comment. Probably we should reject the -gsrc... option if we're emitting DWARF, which requires MD5 (at least so far). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 ___

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462503. thakis added a comment. tweak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/include/clang

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis created this revision. thakis added a reviewer: hans. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. Based on a patch by Arlo Siemsen (D98438 )! https://reviews.llvm.org/D134544 Files: clang/in