This revision was automatically updated to reflect the committed changes.
python3kgae marked an inline comment as done.
Closed by commit rG15aa64301ab1: [HLSL] Support register binding attribute on
global variable (authored by python3kgae).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134617/new/
https://reviews.llvm.org/D134617
python3kgae marked an inline comment as done.
python3kgae added inline comments.
Comment at: clang/include/clang/Parse/Parser.h:2817-2818
+ void MaybeParseHLSLSemantics(Declarator &D,
+ SourceLocation *EndLoc = nullptr) {
+if (Tok.is(tok::colo
python3kgae updated this revision to Diff 465115.
python3kgae added a comment.
Limit MaybeParseHLSLSemantics to HLSL.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134617/new/
https://reviews.llvm.org/D134617
Files:
clang/include/clang/Basic/Att
aaron.ballman added inline comments.
Comment at: clang/include/clang/Parse/Parser.h:2817-2818
+ void MaybeParseHLSLSemantics(Declarator &D,
+ SourceLocation *EndLoc = nullptr) {
+if (Tok.is(tok::colon)) {
aaron.ballman wrote:
python3kgae added inline comments.
Comment at: clang/test/SemaHLSL/resource_binding_attr_error.hlsl:51
+}
+
+struct S {
aaron.ballman wrote:
> Let's add another test for a local extern, like:
> ```
> void func() {
> extern RWBuffer U : register(u5);
> }
> ```
N
python3kgae updated this revision to Diff 464346.
python3kgae marked 3 inline comments as done.
python3kgae added a comment.
Ignore local extern decl when check ExternalGlobalVar
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134617/new/
https://rev
aaron.ballman added inline comments.
Comment at: clang/include/clang/Parse/Parser.h:2817-2818
+ void MaybeParseHLSLSemantics(Declarator &D,
+ SourceLocation *EndLoc = nullptr) {
+if (Tok.is(tok::colon)) {
Let's assert we're in
python3kgae updated this revision to Diff 462819.
python3kgae added a comment.
Remove empty line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134617/new/
https://reviews.llvm.org/D134617
Files:
clang/include/clang/Basic/Attr.td
clang/include
python3kgae created this revision.
python3kgae added reviewers: beanz, pow2clk, bogner.
Herald added a reviewer: aaron.ballman.
Herald added a subscriber: Anastasia.
Herald added a project: All.
python3kgae requested review of this revision.
Herald added a project: clang.
Herald added a subscriber:
10 matches
Mail list logo