This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG578b0bd4e621: [Clang][AArch64][SME] Add ZA zeroing
intrinsics (authored by bryanpkc).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
___
cfe-commits mailing list
cfe-com
bryanpkc updated this revision to Diff 540838.
bryanpkc added a comment.
Removed the attribute macro as suggested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
Files:
clang/include/clang/Basic/arm_sme.td
clang/include/clang/Basic/arm_sv
sdesmalen added a comment.
Other than my comment on the test, the patch looks good to me.
Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_zero.c:20
+//
+ARM_SHARED_ZA_ATTR void test_svzero_mask_za() {
+ svzero_mask_za(0);
The new keyword attribu
bryanpkc updated this revision to Diff 532431.
bryanpkc marked 3 inline comments as done.
bryanpkc added a comment.
Rebased. NFC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
Files:
clang/include/cla
bryanpkc updated this revision to Diff 531330.
bryanpkc added a comment.
Addressed @sdesmalen's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
Files:
clang/include/clang/Basic/arm_sme.td
cl
sdesmalen added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9921-9922
return EmitSMEReadWrite(TypeFlags, Ops, Builtin->LLVMIntrinsic);
+ else if (TypeFlags.isZero())
+return EmitSMEZero(TypeFlags, Ops, Builtin->LLVMIntrinsic);
Given t
bryanpkc updated this revision to Diff 526351.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
Files:
clang/include/clang/Basic/TargetBuiltins.h
clang/include/clang/Basic/arm_sme.td
clang/include/clang/Basic/arm_sve_sme_incl.td
clang/lib
bryanpkc updated this revision to Diff 492680.
bryanpkc added a comment.
Update patch with more context.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
Files:
clang/include/clang/Basic/TargetBuiltins.h
bryanpkc updated this revision to Diff 487384.
bryanpkc retitled this revision from "[Clang][AArch64] Add SME zero intrinsic"
to "[Clang][AArch64][SME] Add ZA zeroing intrinsics".
bryanpkc edited the summary of this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
10 matches
Mail list logo