[PATCH] D135258: [SourceManager] Improve getFileIDLoaded.

2022-10-06 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rGdf61bb271af9: [SourceManager] Improve getFileIDLoaded. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D135258?vs=465345&id=465678#toc R

[PATCH] D135258: [SourceManager] Improve getFileIDLoaded.

2022-10-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Just a couple of comments where we could take the opportunity to clarify the existing code. Optional. Comment at: clang/lib/Basic/SourceManager.cpp:874 +int

[PATCH] D135258: [SourceManager] Improve getFileIDLoaded.

2022-10-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. Similar to getFileIDLocal patch, but for the versio