[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet added a comment. In D135340#3882280 , @thakis wrote: > This is still breaking ` Profile-x86_64 :: instrprof-darwin-dead-strip.c` > on mac. I'm reverting this again for now. Sorry about that, I've tested it locally and it should be good to go

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet updated this revision to Diff 470597. abrachet added a comment. Use sed to filter nm output instead of grep. grep exits with exit code 1 because there are no matching lines. This is expected because there are no more external symbols other than `_main` and `__mh_execute_header`, note `_

[PATCH] D135340: [PGO] Make emitted symbols hidden

thakis added a comment. This is still breaking ` Profile-x86_64 :: instrprof-darwin-dead-strip.c` on mac. I'm reverting this again for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135340/new/ https://reviews.llvm.org/D135340 ___ cfe-

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet updated this revision to Diff 468425. abrachet added a comment. The error @zequanwu ran into happens only on MacOS because it this Darwin-only test happens to be the only one that tests instrprof with no code. `__llvm_profile_filename` doesn't get emitted in this case so it ends up pul

[PATCH] D135340: [PGO] Make emitted symbols hidden

zequanwu added a comment. This causing instrprof-darwin-dead-strip.c failed on mac. FAIL: Profile-x86_64 :: instrprof-darwin-dead-strip.c (1 of 238) TEST 'Profile-x86_64 :: instrprof-darwin-dead-strip.c' FAILED Script: -- : 'RUN: at line 4';

[PATCH] D135340: [PGO] Make emitted symbols hidden

This revision was automatically updated to reflect the committed changes. Closed by commit rGecac223b0e4b: [PGO] Make emitted symbols hidden (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT