[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-13 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 467491. francii added a comment. Updated check for Func name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/lib/Basic/Targets/OSTargets.h clang/test

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-12 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comment; thanks! Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:39 +Triple TargetTriple(M.getTargetTriple

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-12 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 467351. francii added a comment. "Added check for __mcount on aix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/lib/Basic/Targets/OSTargets.h clang

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-11 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:38-40 +const Twine targetTwine(M.getTargetTriple()); +Triple targetTriple(targetTwine); +if (targetTriple.isOSAIX()) { A `Twine` can be impli

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-11 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 466852. francii added a comment. Updated target triple check to use isOSAIX() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/test/CodeGen/mcount-aix.c

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-11 Thread Chris Bowler via Phabricator via cfe-commits
cebowleratibm added inline comments. Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:38 +const std::string &targetTriple = M.getTargetTriple(); +if (targetTriple.find("powerpc-ibm-aix") == std::string::npos || +targetTriple.find("powerpc64-ibm-aix"

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-07 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 466254. francii added a comment. Replace target pointers with opaque pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/test/CodeGen/mcount-aix.c

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-07 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 466252. francii added a comment. Removed __mcount.aix usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/test/CodeGen/mcount-aix.c llvm/lib/Transf

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-07 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 466248. francii added a comment. Removed use of -no-opaque-pointers and call to "__mcount.aix" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/test/Cod

[PATCH] D135384: [AIX] Enable the use of the -pg flag

2022-10-07 Thread Chris Bowler via Phabricator via cfe-commits
cebowleratibm added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:754 : OSTargetInfo(Triple, Opts) { +this->MCountName = "__mcount.aix"; this->TheCXXABI.set(TargetCXXABI::XL); Suggest sticking with the normal mcount name and rem