This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG39b9d4f188ca: [clang][dataflow] Add support for a Top value
in boolean formulas. (authored by ymandel).
Repository:
rG LLVM Github Monorepo
CHANG
ymandel updated this revision to Diff 467822.
ymandel marked an inline comment as done.
ymandel added a comment.
rebase onto a recent HEAD
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files:
clang/in
ymandel marked an inline comment as done.
ymandel added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/SolverTest.cpp:69
-TEST(SolverTest, UnitConflict) {
- ConstraintContext Ctx;
gribozavr2 wrote:
> Why delete this test?
That was a mistak
ymandel updated this revision to Diff 467746.
ymandel marked an inline comment as done.
ymandel added a comment.
Adding back accidentally deleted test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/SolverTest.cpp:69
-TEST(SolverTest, UnitConflict) {
- ConstraintContext Ctx;
Why delete this test?
Repository:
rG LLVM Github Monorepo
ymandel updated this revision to Diff 467611.
ymandel added a comment.
fix typos
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext
ymandel marked 6 inline comments as done.
ymandel added inline comments.
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:527-528
+auto *Prop2 = Val2.getProperty("has_value");
+return Prop1 == Prop2 || (Prop1 != nullptr && Prop2 != nu
ymandel updated this revision to Diff 467609.
ymandel added a comment.
Added FIXMEs for noted issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files:
clang/include/clang/Analysis/FlowSensitive/Da
xazax.hun added inline comments.
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1192
+ const Environment &Env1, const Value &Val2,
+ const Environment &Env2) final {
+// Changes to a sound
xazax.hun added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+return takeOwnership(std::make_unique());
+ }
ymandel wrote:
> xazax.hun wrote:
> > gribozavr2 wrote:
> > > yma
ymandel updated this revision to Diff 467589.
ymandel marked an inline comment as done.
ymandel added a comment.
added another test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files:
clang/include/c
ymandel marked 5 inline comments as done.
ymandel added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+return takeOwnership(std::make_unique());
+ }
xazax.hun wrote:
> griboz
ymandel updated this revision to Diff 467513.
ymandel added a comment.
Add explicit test for creation of multiple tops.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files:
clang/include/clang/Analysi
ymandel updated this revision to Diff 467510.
ymandel marked 6 inline comments as done.
ymandel added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files:
clang/include/cl
xazax.hun added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+return takeOwnership(std::make_unique());
+ }
gribozavr2 wrote:
> ymandel wrote:
> > xazax.hun wrote:
> > > gri
sgatev added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:156
+ TopBoolValue &createTopBoolValue() {
+return takeOwnership(std::make_unique());
Please add a comment.
Comment at: clang
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+return takeOwnership(std::make_unique());
+ }
ymandel wrote:
> xazax.hun wr
ymandel marked 11 inline comments as done.
ymandel added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:237-238
+ case Value::Kind::Top:
+// Nothing more to do. Each `Top` instance will be mapped to a fresh
+// variabl
ymandel updated this revision to Diff 466124.
ymandel marked an inline comment as done.
ymandel added a comment.
Address (most) comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
Files:
clang/inc
ymandel added a comment.
Thanks for the thorough reviews! Agreed on all points, and will address.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+return takeOwnership(std::make_unique());
+ }
---
xazax.hun added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+return takeOwnership(std::make_unique());
+ }
gribozavr2 wrote:
> Should we be creating a new top every time, o
xazax.hun accepted this revision.
xazax.hun added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:527-528
+auto *Prop2 = Val2.getProperty("has_value");
+return Prop1 =
gribozavr2 added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157
+ TopValue &createTop() {
+return takeOwnership(std::make_unique());
+ }
Should we be creating a new top every time, or should it be a si
ymandel created this revision.
ymandel added reviewers: xazax.hun, sgatev.
Herald added subscribers: martong, rnkovacs.
Herald added a reviewer: NoQ.
Herald added a project: All.
ymandel requested review of this revision.
Herald added a project: clang.
Currently, our boolean formulas (`BoolValue`)
24 matches
Mail list logo
