[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0dec5e164f9d: Keep configuration file search directories in ExpansionContext. NFC (authored by sepavloff). Repository: rG LLVM Github Monorepo CH

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff added a comment. In D135439#3864165 , @MaskRay wrote: > I am not familiar with `ExpansionContext`. Is there any behavior difference > which can be demonstrated by a test? This is an NFC test, it does not change behavior. However moving these

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

MaskRay added a comment. I am not familiar with `ExpansionContext`. Is there any behavior difference which can be demonstrated by a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.org/D135439 _

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.org/D135439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I haven't tested it but eyeball-review, it looks neat. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.or

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2138 + /// directories specified by SearchDirs field. + bool findConfigFile(StringRef FileName, std::string &FilePath); + mgorny wrote: > I'm sorry if I'm missing something obv

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff updated this revision to Diff 468137. sepavloff added a comment. Change parameter type of findConfigFile, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.org/D135439 Files: clang/include/clang/Dri

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2138 + /// directories specified by SearchDirs field. + bool findConfigFile(StringRef FileName, std::string &FilePath); + I'm sorry if I'm missing something obvious but is there a

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { mgorny wrote: > I don't really understand t

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { I don't really understand the purpose of th

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff created this revision. sepavloff added reviewers: MaskRay, mgorny. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. Class ExpansionContex