[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. This broke a reverse iteration bot: https://lab.llvm.org/buildbot#builders/54/builds/3337 Forward fix in: https://reviews.llvm.org/D142127 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG557a5bc336ff: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 490323. paulkirth added a comment. Herald added a subscriber: luke. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added a comment. Thanks. I have noticed I suggested re-typo. (I didn't amend it since I thought it was obvious) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 ___

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth marked 3 inline comments as done. paulkirth added a comment. @chapuni Thanks for the suggestion. It didn't occur to me that it could break the lines like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llv

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489147. paulkirth added a comment. Use more flexible whitespace matching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added inline comments. Comment at: clang/test/Frontend/stack-layout-remark.c:24 +// YAML: Name:StackLayout +// YAML: DebugLoc:{ File: '{{.*}}stack-layout-remark.c', Line: [[# @LINE + 24]], +// YAML: Function:foo chapuni wrote:

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added a comment. This failed on some environments. See https://lab.llvm.org/buildbot/#/builders/109/builds/55534 Comment at: clang/test/Frontend/stack-layout-remark.c:24 +// YAML: Name:StackLayout +// YAML: DebugLoc:{ File: '{{.*}}stack-layout-remar

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a652c540556: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. @nickdesaulniers @thegameg Are we happy w/ the ReleaseNotes and the documentation changes? If so, I'll land this, but I wasn't sure either of you saw those changes ... or if using `isFunctionInPrintList` for now is a good choice until we can implement filtering for re

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489036. paulkirth added a comment. Fix test for Windows. I had missed one of the file paths in YAML. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. In D135488#4049075 , @thegameg wrote: > I would rather have a more generic mechanism for remarks or diagnostics in > general. Even if it uses `isFunctionInPrintList`, I'd rather have a real flag > that doesn't require `-mllvm`

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 488842. paulkirth marked 5 inline comments as done. paulkirth retitled this revision from "[codegen] Add a remarks based Stack Layout Analysis pass" to "[codegen] Add StackFrameLayoutAnalysisPass". paulkirth edited the summary of this revision. paulkirth add