[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

This revision was automatically updated to reflect the committed changes. Closed by commit rG0303eafcb346: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer` (authored by isuckatcs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/ne

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. > As long as you don't need the library (which, if you have a preprocessed file > or a test, should absolutely not be necessary), you can just do the -cc1 > option of -triple , or the non- -cc1 option of -target . > > Both use basically the same options list, and that

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 500299. isuckatcs added a comment. Fixed the timed out test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tid

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

erichkeane added a comment. In D135495#4151238 , @isuckatcs wrote: > I'm not sure if I can run clang targetting AArch64 on an X86 machine but I > tried it regardless and I get compiler errors on startup, so I can't debug > this issue at the moment. > B

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. I'm not sure if I can run clang targetting AArch64 on an X86 machine but I tried it regardless and I get compiler errors on startup, so I can't debug this issue at the moment. Besided that I don't know why it times out on that buildbot. The build job that is performe

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

DavidSpickett added a comment. If it helps, the bot I linked is pretty vanilla. You can find all the details in the buildbot UI but just in case: cmake -G Ninja ../llvm/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=True '-DLLVM_LIT_ARGS='"'"'-v'"'"'' -DCMAKE_INSTALL_PREFIX=../stag

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

DavidSpickett added a comment. The test was timing out on Arm/AArch64 bots so I have reverted this change. I think because there were other test failures on the initial run, that obscured the time out. This is one of the first builds to include this change: https://lab.llvm.org/buildbot/#/build

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b0cf1e15f8f: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer` (authored by isuckatcs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/ne

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 40. isuckatcs added a comment. fixed failing test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/util

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

xazax.hun added a comment. I think at this point it is ok to merge. Any other comments can be addressed in follow-up commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. @xazax.hun can we merge this or should we wait for someone else's approval too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 499453. isuckatcs added a comment. Added tests for function pointers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/