[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not 100% sure why this was done in the first pl

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

aaron.ballman added a comment. This function is testing whether something is potentially a constant expression. Something might not be a valid constant expression for two reasons: 1) it uses some prohibited language construct, 2) it hit undefined behavior. You don't know if you hit undefined be

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

tbaeder added a comment. In D135569#3847493 , @aaron.ballman wrote: > This function is testing whether something is potentially a constant > expression. Something might not be a valid constant expression for two > reasons: 1) it uses some prohibited la

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this change makes sense to me. Ultimately, this API is about the potential to be constexpr, so there's no need to pay for the expense of running the function with some gi

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

This revision was automatically updated to reflect the committed changes. Closed by commit rG1928da1ef73c: [clang][Interp] Don't run functions immediately after compiling them (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135569?vs=466462&id=467706#toc Repository: