[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ce1339264d: [clang] Do not override libclang.so's SOVERSION if… (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny added a comment. In D135701#3850251 , @MaskRay wrote: > I don't understand this well, though. Is `CLANG_VERSION_MAJOR` wrong or not > defined in some cases? It's about `LLVM_VERSION_SUFFIX`. Normally, `SOVERSION` for all libraries is `${LLVM_VER

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

MaskRay accepted this revision. MaskRay added a comment. I don't understand this well, though. Is `CLANG_VERSION_MAJOR` not defined in some cases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135701/new/ https://reviews.llvm.org/D135701 ___

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. It fixes a real-life issue I hit with Doxygen, as you know, so I'm happy with this - and I don't see a reason to treat libclang specially. I'll wait to see what any other reviewers say

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny created this revision. mgorny added reviewers: thieta, h-vetinari, tstellar, MaskRay, thesamesam. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. mgorny requested review of this revision. Instead of setting libclang.so's SOVERSION to CLANG_MAJOR_VERSION whe