[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thieta added a comment. I posted https://reviews.llvm.org/D137322 to remove `-fmessage-length` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-commits

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

This revision was automatically updated to reflect the committed changes. Closed by commit rG29a500b346bd: [CodeView][clang] Add flag to disable emitting command line into CodeView (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

rnk accepted this revision. rnk added a comment. I'm happy with this if it works for everyone else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Please mention the default value of the flag in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4354 + +// Emit codeview command line if requested. +if (Args.hasFlag(options::OPT_gcodeview_command_line, aganea wrote: > aeubanks wrote: > > MaskRay wrote: > > > This

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks updated this revision to Diff 469954. aeubanks added a comment. default to off Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aganea added a subscriber: stefan_reinalter. aganea added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4354 + +// Emit codeview command line if requested. +if (Args.hasFlag(options::OPT_gcodeview_command_line, aeubanks wrote: >

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks added a comment. In D136474#3875442 , @aganea wrote: > Thanks for the patch @aeubanks and apologies for this oversight. I am > wondering however if it wouldn’t make more sense to just strip this flag > (-fmessage-length) from the emitted

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks updated this revision to Diff 469733. aeubanks added a comment. add driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thakis added a comment. There will be other problems like this. We don't care about having the command in the debug info and we'd rather get rid of this class of bugs Once And For All :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aganea added a comment. Thanks for the patch @aeubanks and apologies for this oversight. I am wondering however if it wouldn’t make more sense to just strip this flag (-fmessage-length) from the emitted cmd-line? The goal is to provide a reproducer, this flag does not matter for that purpose.

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4354 + +// Emit codeview command line if requested. +if (Args.hasFlag(options::OPT_gcodeview_command_line, This needs a test in clang/test/Driver/ Use `addOptInFlag`

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. In https://reviews.llvm.org/D80833, there were concerns about determinism emitting the commandline into CodeView.